[lambda][flare] Build endpoint URL from environment variables #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
duncanista
reviewed
Jul 11, 2023
duncanista
reviewed
Jul 11, 2023
duncanista
reviewed
Jul 11, 2023
duncanista
reviewed
Jul 11, 2023
duncanista
reviewed
Jul 11, 2023
duncanista
requested changes
Jul 11, 2023
duncanista
reviewed
Jul 11, 2023
duncanista
reviewed
Jul 11, 2023
duncanista
reviewed
Jul 12, 2023
Comment on lines
+735
to
+741
| beforeEach(() => { | ||
| process.env = {...ORIGINAL_ENV} | ||
| }) | ||
|
|
||
| afterAll(() => { | ||
| process.env = ORIGINAL_ENV | ||
| }) |
nhulston
deleted the
nicholas.hulston/serverless-flare/use-dd-site-for-endpoint-url
branch
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
We want to use environment variables
DATADOG_SITEorDD_SITEto build the endpoint URL to send flare files to. This ensures that user experience low latencies.In the case where neither environment variable is set, we will use
DATADOG_SITE_US1 = 'datadoghq.com'to default toUS1.How?
getEndpointUrl()function that calculates and returns the full endpoint URL as a stringDATADOG_SITE, (2)DD_SITE, or (3) the default Datadog siteDATADOG_SITE_US1, if neither environment variable is set.https://to the endpointReview checklist